Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GlobalRole platform-self-provisioner #2095

Merged
merged 4 commits into from
Sep 15, 2022

Conversation

zhou1203
Copy link
Member

@zhou1203 zhou1203 commented Aug 31, 2022

Add GlobalRole platform-self-provisioner and GlobalRole role-template-create-workspaces

Signed-off-by: Wenhao Zhou wenhaozhou@yunify.com

@ks-ci-bot ks-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 31, 2022
@zhou1203
Copy link
Member Author

/cc @wansir @pixiake

@ks-ci-bot ks-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 1, 2022
@wansir
Copy link
Member

wansir commented Sep 15, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: e65b1a63fcb6c18c59c4d7dbb24d6b32ff3ab16a

…-create-workspaces

Signed-off-by: Wenhao Zhou <wenhaozhou@yunify.com>
…templates

Signed-off-by: Wenhao Zhou <wenhaozhou@yunify.com>
Signed-off-by: Wenhao Zhou <wenhaozhou@yunify.com>
…spaces

Signed-off-by: Wenhao Zhou <wenhaozhou@yunify.com>
@ks-ci-bot ks-ci-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase labels Sep 15, 2022
@pixiake
Copy link
Collaborator

pixiake commented Sep 15, 2022

/approve
/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@pixiake: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/approve
/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, zhou1203

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@pixiake
Copy link
Collaborator

pixiake commented Sep 15, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: d1869a51a17175673f3b4f4c78724bcec2ac5a7b

@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #2107

In response to this:

/approve
/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants