Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an admission webhook for cluster crd #2131

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

yzxiu
Copy link
Contributor

@yzxiu yzxiu commented Oct 17, 2022

Signed-off-by: yzx 946666800@qq.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add an admission webhook for cluster crd to check cluster ID (kube-system UID) before updating

Does this PR introduced a user-facing change?

Must be used with the updated ks-controller-manager to avoid cluster crd update failures.

see kubesphere/kubesphere#5299

@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2022
@yzxiu yzxiu changed the title Add an admission webhook for cluster crd to check cluster ID (kube-system UID) before updating Add an admission webhook for cluster crd Oct 17, 2022
@yzxiu
Copy link
Contributor Author

yzxiu commented Oct 20, 2022

/assign @pixiake

@wansir
Copy link
Member

wansir commented Oct 20, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 5f18e2cc8d820e317d9536aa06ce4b1c342604b8

@pixiake
Copy link
Collaborator

pixiake commented Jan 16, 2023

/cherry-pick release-3.3

/approve

@ks-ci-bot
Copy link
Collaborator

@pixiake: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-3.3

/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, yzxiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@ks-ci-bot ks-ci-bot merged commit 453ce5d into kubesphere:master Jan 16, 2023
@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #2162

In response to this:

/cherry-pick release-3.3

/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants