-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade logsidecar injector version to v1.2.0 #2154
Conversation
/cc @benjaminhuo /cherry-pick release-3.3 |
@junotx: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@junotx It should be pick into kse-3.x and kse-release-3.3 as well |
@@ -4,7 +4,7 @@ description: A Helm chart for logsidecar-injector | |||
icon: | |||
type: application | |||
version: 0.1.0 | |||
appVersion: 0.1.0 | |||
appVersion: "v1.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually the appVersion if without v
Signed-off-by: junot <junotxiang@kubesphere.io>
/lgtm |
LGTM label has been added. Git tree hash: 43b2e2513c7f6ac69d39d88aa0cda8834ec2ac3a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminhuo, junotx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@junotx: new pull request created: #2157 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
upgrade logsidecar injector version to v1.2.0 to fix the issue kubesphere/kubesphere#5469