Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade logsidecar injector version to v1.2.0 #2154

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

junotx
Copy link
Contributor

@junotx junotx commented Jan 13, 2023

upgrade logsidecar injector version to v1.2.0 to fix the issue kubesphere/kubesphere#5469

Upgrade logsidecar injector version to v1.2.0 which fixes config parsing bug

@ks-ci-bot ks-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 13, 2023
@junotx
Copy link
Contributor Author

junotx commented Jan 13, 2023

/cc @benjaminhuo

/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@junotx: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cc @benjaminhuo

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benjaminhuo
Copy link
Member

@junotx It should be pick into kse-3.x and kse-release-3.3 as well

@@ -4,7 +4,7 @@ description: A Helm chart for logsidecar-injector
icon:
type: application
version: 0.1.0
appVersion: 0.1.0
appVersion: "v1.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually the appVersion if without v

Signed-off-by: junot <junotxiang@kubesphere.io>
@benjaminhuo
Copy link
Member

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 43b2e2513c7f6ac69d39d88aa0cda8834ec2ac3a

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminhuo, junotx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@ks-ci-bot ks-ci-bot merged commit a705d2e into kubesphere:master Jan 16, 2023
@ks-ci-bot
Copy link
Collaborator

@junotx: new pull request created: #2157

In response to this:

/cc @benjaminhuo

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@junotx junotx deleted the logsidecar branch February 28, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants