Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: slice replace loop #300

Merged
merged 1 commit into from
Sep 20, 2023
Merged

chore: slice replace loop #300

merged 1 commit into from
Sep 20, 2023

Conversation

testwill
Copy link

replace loop with fmAuditResults[result.NameSpace] = append(fmAuditResults[result.NameSpace], result.ResultInfos...)
replace loop with output = append(output, r...)

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2023
@liangzai006
Copy link
Collaborator

@testwill Thanks for this contribution !
/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023
@pixiake
Copy link
Collaborator

pixiake commented Sep 20, 2023

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangzai006, pixiake, testwill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@ks-ci-bot ks-ci-bot merged commit 3256882 into kubesphere:main Sep 20, 2023
3 checks passed
@testwill testwill deleted the replace-loop branch September 20, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants