Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] It doesn't work fro containerd when I set cluster.registry.dataRoot #1449

Closed
life- opened this issue Aug 16, 2022 · 4 comments · Fixed by #1450
Closed

[Bug] It doesn't work fro containerd when I set cluster.registry.dataRoot #1449

life- opened this issue Aug 16, 2022 · 4 comments · Fixed by #1450
Assignees
Labels
bug Something isn't working

Comments

@life-
Copy link
Contributor

life- commented Aug 16, 2022

What is version of KubeKey has the issue?

v2.1.0

What is your os environment?

CentOS 7

KubeKey config file

apiVersion: kubekey.kubesphere.io/v1alpha2
kind: Cluster
metadata:
  name: sample
spec:
  hosts:
  - {name: node1, address: 172.16.0.2, internalAddress: 172.16.0.2, user: ubuntu, password: "Qcloud@123"}
  - {name: node2, address: 172.16.0.3, internalAddress: 172.16.0.3, user: ubuntu, password: "Qcloud@123"}
  roleGroups:
    etcd:
    - node1
    control-plane:
    - node1
    worker:
    - node1
    - node2
  controlPlaneEndpoint:
    ## Internal loadbalancer for apiservers
    # internalLoadbalancer: haproxy

    domain: lb.kubesphere.local
    address: ""
    port: 6443
  kubernetes:
    version: v1.23.9
    clusterName: cluster.local
    autoRenewCerts: true
    containerManager: containerd
  etcd:
    type: kubekey
  network:
    plugin: calico
    kubePodsCIDR: 10.233.64.0/18
    kubeServiceCIDR: 10.233.0.0/18
    ## multus support. https://github.com/k8snetworkplumbingwg/multus-cni
    multusCNI:
      enabled: false
  registry:
    privateRegistry: ""
    namespaceOverride: ""
    registryMirrors: []
    insecureRegistries: []
    dataRoot: "/data/containerd"
  addons: []

A clear and concise description of what happend.

I change kubernetes.containerManager to containerd, and I set registry.dataRoot to another directory ("/data/containerd" in the example), but it does not work for containerd.

Relevant log output

No response

Additional information

No response

@life- life- added the bug Something isn't working label Aug 16, 2022
@24sama
Copy link
Collaborator

24sama commented Aug 16, 2022

I checked this PR: https://github.com/kubesphere/kubekey/pull/1375/files
The dataRoot field is only for docker. So it's just a temporary method that configures the container manager in the .spec.registry.xxx. Maybe we will refactor the container manager configuration.

@life-
Copy link
Contributor Author

life- commented Aug 16, 2022

Should I add dataRoot setting function for containerd current. Maybe you could tell me the plan of refactor container manager configuration. @24sama

@24sama
Copy link
Collaborator

24sama commented Aug 16, 2022

Currently, welcome to create PR and follow the existed logic to configure the containerd, just like the above PR to configure the docker.
The work of code refactor maybe will not come soon, it's just an idea in my mind. If you have any great ideas or suggestions, welcome to leave some comments.

@life-
Copy link
Contributor Author

life- commented Aug 16, 2022

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants