Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AddonsModule must need a network plugin enabled limit #889

Closed
24sama opened this issue Dec 15, 2021 · 3 comments
Closed

Remove AddonsModule must need a network plugin enabled limit #889

24sama opened this issue Dec 15, 2021 · 3 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@24sama
Copy link
Collaborator

24sama commented Dec 15, 2021

Your current KubeKey version

v2.0.0-alpha.1

Describe this feature

For now, AddonsModule must need a network plugin enabled to run. But sometimes, we need to use the AddonsModule to deploy a network plugin because that may be more flexible. So, I think we can remove this limit.

Describe the solution you'd like

Remove AddonsModule must need a network plugin enabled limit. Remove the following Skip fields.

kubekey/pkg/pipelines/create_cluster.go

Line 74 in 213541c

&addons.AddonsModule{Skip: noNetworkPlugin},

kubekey/pkg/pipelines/create_cluster.go

Line 141 in 213541c

&addons.AddonsModule{Skip: noNetworkPlugin},

Additional information

No response
@24sama
Copy link
Collaborator Author

24sama commented Dec 15, 2021

/good-first-issue

@ks-ci-bot
Copy link
Collaborator

@24sama:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 15, 2021
@tanguofu tanguofu mentioned this issue Dec 16, 2021
Merged
ks-ci-bot added a commit that referenced this issue Dec 17, 2021
@ks-ci-bot
Merge pull request #896 from tanguofu/master
44d0263 
fix(kk): #889 Remove AddonsModule must need a network plugin enabled
ks-ci-bot pushed a commit to ks-ci-bot/kubekey that referenced this issue Dec 17, 2021
fix(kk): kubesphere#889 Remove AddonsModule must need a network plugi…
09e5090 
…n enabled limit
ks-ci-bot added a commit that referenced this issue Dec 17, 2021
@ks-ci-bot
Merge pull request #897 from ks-ci-bot/cherry-pick-896-to-release-2.0
b840da9 
[release-2.0] fix(kk): #889 Remove AddonsModule must need a network plugin enabled
@24sama
Copy link
Collaborator Author

24sama commented Dec 17, 2021 •
edited

Fixes: #896

@24sama 24sama closed this as completed Dec 17, 2021
@24sama 24sama mentioned this issue Jan 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@24sama @ks-ci-bot