Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom dnsDomain for cluster #1003

Merged
merged 1 commit into from Jan 14, 2022
Merged

Conversation

pixiake
Copy link
Collaborator

@pixiake pixiake commented Jan 13, 2022

What does this PR do?

Support custom dnsDomain for cluster.

Signed-off-by: pixiake guofeng@yunify.com

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2022
@pixiake pixiake linked an issue Jan 13, 2022 that may be closed by this pull request
@pixiake
Copy link
Collaborator Author

pixiake commented Jan 13, 2022

/cc @RolandMa1986 @24sama

@RolandMa1986
Copy link
Member

@pixiake Do we need to change this function too?

clusterSvc := fmt.Sprintf("kubernetes.default.svc.%s", cfg.Kubernetes.ClusterName)

Signed-off-by: pixiake <guofeng@yunify.com>
@pixiake
Copy link
Collaborator Author

pixiake commented Jan 14, 2022

@pixiake Do we need to change this function too?

clusterSvc := fmt.Sprintf("kubernetes.default.svc.%s", cfg.Kubernetes.ClusterName)

Yes, it needs to be modified. I have changed it.

@RolandMa1986
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 3813e228a291fc2c4588a8cc6f246c10745fee1c

@ks-ci-bot ks-ci-bot merged commit d6e89b7 into kubesphere:master Jan 14, 2022
@pixiake
Copy link
Collaborator Author

pixiake commented Jan 14, 2022

/cherrypick release-2.0

@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #1006

In response to this:

/cherrypick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClusterName is alway same to dnsDomain when creating Kubernetes Cluster
3 participants