New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Kata and Node Feature Discovery #1010
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pixiake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pkg/images/tasks.go
Outdated
// load balancer | ||
"haproxy": {RepoAddr: kubeConf.Cluster.Registry.PrivateRegistry, Namespace: "library", Repo: "haproxy", Tag: "2.3", Group: kubekeyv1alpha2.Worker, Enable: kubeConf.Cluster.ControlPlaneEndpoint.IsInternalLBEnabled()}, | ||
// kata-deploy | ||
"kata-deploy": {RepoAddr: kubeConf.Cluster.Registry.PrivateRegistry, Namespace: kubekeyv1alpha2.DefaultKubeImageNamespace, Repo: "kata-deploy", Tag: "stable", Group: kubekeyv1alpha2.Worker, Enable: kubeConf.Cluster.Kubernetes.EnableKata}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there only worker nodes that can use the kata containers
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, kata does not support host network, the control-plane components uses runc, so kata is not needed on the control-plane.
EtcdBackupScriptDir string `yaml:"etcdBackupScript" json:"etcdBackupScript,omitempty"` | ||
ContainerManager string `yaml:"containerManager" json:"containerManager,omitempty"` | ||
ContainerRuntimeEndpoint string `yaml:"containerRuntimeEndpoint" json:"containerRuntimeEndpoint,omitempty"` | ||
EnableNodeFeatureDiscovery bool `yaml:"enableNodeFeatureDiscovery" json:"enableNodeFeatureDiscovery,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you think to use a struct
to configure the kata
and NodeFeatureDiscovery
?
Just like:
Kata:
enable: true
moreOptions: xxxx
NodeFeatureDiscovery:
enable: false
BTW, if we use this structure, in the golang struct, the type of the enable
field we can set as *bool
. This allows you to distinguish between "true", "false" and "not set".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I will update it.
Signed-off-by: pixiake <guofeng@yunify.com>
/lgtm |
LGTM label has been added. Git tree hash: 1bd18bd41e81629406f9a016518c052dade7500a
|
/cherrypick release-2.0 |
@24sama: new pull request created: #1024 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What does this PR do ?
Support installation of kata-container and node-feature-discovery using kubekey.
Kata Containers is an open source community working to build a secure container runtime with lightweight virtual machines that feel and perform like containers, but provide stronger workload isolation using hardware virtualization technology as a second layer of defense.
NodeFeatureDiscovery detects hardware features available on each node in a Kubernetes cluster, and advertises those features using node labels.
How to use ?
add
spec.kubernetes.enableKata: true
orspec.kubernetes.enableNodeFeatureDiscovery: true
containerd
andcri-o
.example:
Signed-off-by: pixiake guofeng@yunify.com