Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest module detects cluster images way by pods #1012

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

24sama
Copy link
Collaborator

@24sama 24sama commented Jan 17, 2022

What does this PR do?

Before, the manifest module detected the cluster images by .node.Status.Images, and these fields may contain some host local image that the k8s cluster doesn't use. So, this PR makes this module detect cluster images by pods' containers and initContainers.

Signed-off-by: 24sama <leo@kubesphere.io>
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2022
@pixiake
Copy link
Collaborator

pixiake commented Jan 17, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 0ace20c13100baf24c6d1c281cdde2ce754c17ff

@pixiake
Copy link
Collaborator

pixiake commented Jan 17, 2022

/cherrypick release-2.0

@ks-ci-bot ks-ci-bot merged commit 301611c into kubesphere:master Jan 17, 2022
@ks-ci-bot
Copy link
Collaborator

@pixiake: once the present PR merges, I will cherry-pick it on top of release-2.0 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #1014

In response to this:

/cherrypick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants