Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The roleGroups field supports to be customized #1018

Merged
merged 1 commit into from Jan 20, 2022

Conversation

24sama
Copy link
Collaborator

@24sama 24sama commented Jan 19, 2022

What does this PR do?

  • The roleGroups field supports to be customized.
  • Change the role master to control-plane

After this PR, we can add other custom roles in the config file. And based on this benefit, we can add a new feature to kk to execute Linux commands on the host with the specified role. For example:

./kk exec "setenforce 0" --roles worker pek

Signed-off-by: 24sama <leo@kubesphere.io>
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 19, 2022
@pixiake
Copy link
Collaborator

pixiake commented Jan 20, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: f88261310ddc89920b566b1a501d03df6559832c

@ks-ci-bot ks-ci-bot merged commit 16fc233 into kubesphere:master Jan 20, 2022
@24sama
Copy link
Collaborator Author

24sama commented Jan 20, 2022

/cherrypick release-2.0

@ks-ci-bot
Copy link
Collaborator

@24sama: new pull request created: #1022

In response to this:

/cherrypick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants