Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README and LOGO #1037

Merged
merged 1 commit into from Feb 7, 2022
Merged

update README and LOGO #1037

merged 1 commit into from Feb 7, 2022

Conversation

pixiake
Copy link
Collaborator

@pixiake pixiake commented Jan 26, 2022

What does this PR do?

  1. update README
  2. update kubekey's logo

Signed-off-by: feng guofeng@yunify.com

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2022
@pixiake
Copy link
Collaborator Author

pixiake commented Jan 26, 2022

/cc @kubesphere/sig-docs

Copy link

@Felixnoo Felixnoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments, thanks.

README.md Outdated

There are three scenarios to use KubeKey.
KubeKey is an open source lightweight tool for deploying kubernetes clusters. It provides a flexible, rapid and convenient way to install Kubernetes/k3s only, both Kubernetes/k3s and KubeSphere, and related cloud-native add-ons. It is also an efficient tool to scale and upgrade your cluster.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open source -> open-source
kubernetes -> Kubernetes
flexible, rapid and convenient -> flexible, rapid, and convenient

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated
There are three scenarios to use KubeKey.
KubeKey is an open source lightweight tool for deploying kubernetes clusters. It provides a flexible, rapid and convenient way to install Kubernetes/k3s only, both Kubernetes/k3s and KubeSphere, and related cloud-native add-ons. It is also an efficient tool to scale and upgrade your cluster.

In addition, KubeKey also supports customized Air-Gap package, which is convenient for users to quickly deploy clusters in offline environment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Air-Gap package -> air-gap packages (As I understand it, KK supports more than one type of air-gap package? Also, if Air-Gap is written to emphasize the air-gap feature, then I'm fine with the capitalization and you can keep it that way.)

offline environment -> offline environments

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, air-gap is a new feature.

README.md Outdated

> **Important:** If you have existing clusters, please refer to [ks-installer (Install KubeSphere on existing Kubernetes cluster)](https://github.com/kubesphere/ks-installer).
There are three scenarios to use KubeKey.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are three scenarios to use KubeKey. -> Use KubeKey in the following three scenarios.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated
## Motivation
* Install Kubernetes/k3s only
* Install Kubernetes/k3s and KubeSphere together in one command
* Install Kubernetes/k3s first, then deploy KubeSphere on it using [ks-installer](https://github.com/kubesphere/ks-installer)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all k3s should be updated to K3s.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated
* KubeKey uses Kubeadm to install K8s cluster on nodes in parallel as much as possible in order to reduce installation complexity and improve efficiency. It will greatly save installation time compared to the older installer.
* KubeKey supports for scaling cluster from allinone to multi-node cluster, even an HA cluster.
* KubeKey aims to install cluster as an object, i.e., CaaO.
> **Important:** If you have existing kubernetes clusters, please refer to [ks-installer (Install KubeSphere on existing Kubernetes cluster)](https://github.com/kubesphere/ks-installer).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes -> Kubernetes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated
@@ -43,6 +42,14 @@ There are three scenarios to use KubeKey.
* **v1.22**:   *v1.22.1*
> Looking for more supported versions [Click here](./docs/kubernetes-versions.md)

### Container Manager
* **Docker** / **Containerd** / **CRI-O** / **iSula**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Containerd -> containerd

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated
@@ -43,6 +42,14 @@ There are three scenarios to use KubeKey.
* **v1.22**:   *v1.22.1*
> Looking for more supported versions [Click here](./docs/kubernetes-versions.md)

### Container Manager
* **Docker** / **Containerd** / **CRI-O** / **iSula**
> `Kata Containers` can be set to automatically install and configure runtime class for it when the container manager is Containerd or CRI-O.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Containerd -> containerd


* `Action`: The most basic unit. It represents one operation performed on one node;
* `Task`: The one that manages `Action`. It contains fields such as `Action`, nodes, whether to retry, whether to execute in parallel, etc. In short, it represents executing an `Action` on the specified nodes as required;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It contains fields such as Action, nodes, whether to retry, whether to execute in parallel, etc.

This sentence looks strange to me, especially the part after Action.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task is the structure defined in the code, the following content describes some fields contained in this structure.

Signed-off-by: feng <guofeng@yunify.com>
@Felixnoo
Copy link

Felixnoo commented Feb 7, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 71e156944659902ce292184cf9b5225dc4301469

@ks-ci-bot ks-ci-bot merged commit 0fc61e4 into kubesphere:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants