Add the support of NamespaceOverride for KubeSphere‘s images #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pixiake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
approved
pixiake
changed the title
Signed-off-by: pixiake <guofeng@yunify.com>
|
/lgtm |
|
LGTM label has been added. Git tree hash: 76fdf39424101fe7936ff23a242e3348d3efe5ed
|
|
/cherrypick release-2.0 |
|
@24sama: new pull request created: #1078 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pixiake guofeng@yunify.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
KubeKey supports
NamespaceOverrideand is only used for deploying kubenretes cluster. However, when deploying KubeSphere at the same time, this parameter has no effect on the images of KubeSphere. When all images use the same namespace, it will lead to the failure of installation.Therefore, this pr adds the support of
NamespaceOverridefor KubeSphere‘s images.