Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add rpms and debs support. #1524

Merged
merged 1 commit into from Sep 26, 2022
Merged

feat: Add rpms and debs support. #1524

merged 1 commit into from Sep 26, 2022

Conversation

kuops
Copy link
Contributor

@kuops kuops commented Sep 24, 2022

What type of PR is this?

What this PR does / why we need it:

/kind feature

Which issue(s) this PR fixes:

Fixes # 1486

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2022
@kuops kuops marked this pull request as ready for review September 25, 2022 02:39
@ks-ci-bot ks-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2022
Copy link
Collaborator

@24sama 24sama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions! Here are some comments, PTAL!

pkg/bootstrap/os/tasks.go Outdated Show resolved Hide resolved
@kuops kuops changed the title feat: Add rpms and deps support. feat: Add rpms and debs support. Sep 26, 2022
@24sama
Copy link
Collaborator

24sama commented Sep 26, 2022

Thanks again! And, it would be better if you can create a new PR to improve the file.

@24sama
Copy link
Collaborator

24sama commented Sep 26, 2022

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: a2d67b5d2afc0e377cf735484cbb6112a33c0295

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama, kuops

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2022
@ks-ci-bot ks-ci-bot merged commit a1c21de into kubesphere:master Sep 26, 2022
@Harris1024
Copy link

OK, great. Thank you very much for your contribution. Our business needs to use this function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants