-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix ubuntu version get #1911
Conversation
/assign @LinuxSuRen |
cmd/kk/pkg/artifact/manifest.go
Outdated
@@ -95,7 +95,9 @@ func CreateManifest(arg common.Argument, name string) error { | |||
case "ubuntu": | |||
id = "ubuntu" | |||
v := strings.Split(osImageArr[1], ".") | |||
version = fmt.Sprintf("%s.%s", v[0], v[1]) | |||
if len(v) == 2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer using len(v) >= 2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reasonable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 5c59dc466c2928013ac6d09498c83d18e151d8a3
|
@all-contributors please add @wongearl for code |
@littleBlackHouse I've put up a pull request to add @wongearl! 🎉 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LinuxSuRen, littleBlackHouse, wongearl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: fix ubuntu version get
Which issue(s) this PR fixes:
Fixes #1910
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: