Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pull images from harbor pivate registry ImagePullBackOff #2040

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

qyz87
Copy link
Contributor

@qyz87 qyz87 commented Nov 9, 2023

ensure docker credentials save to $HOME/.docker/config.json

What type of PR is this?

kind bug

What this PR does / why we need it:

centos use "Defaults always_set_home" in /etc/sudoers, then HOME in env is "/root" when use sudo ,so config.json is always saved to /root/.docker/config.json,then "mkdir -p /.docker && cp -f $HOME/.docker/config.json /.docker/ && chmod 0644 /.docker/config.json " will be failed. Kubelet pull images from harbor pivate registry ImagePullBackOff

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


ensure docker credentials save to $HOME/.docker/config.json
@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2023
@qyz87
Copy link
Contributor Author

qyz87 commented Nov 9, 2023

/assign @rayzhou2017

@pixiake
Copy link
Collaborator

pixiake commented Nov 14, 2023

@qyz87 Thnaks for this contribution !
/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: f217747a8f04b3af82542bb727ae79bef9d25b16

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, qyz87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2023
@ks-ci-bot ks-ci-bot merged commit 1d24bd7 into kubesphere:master Nov 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants