Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support use docker for version >= v1.24.0 #2111

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

chilianyi
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # Support use docker for version >= v1.24.0

Special notes for reviewers:


when create cluster with k8s version >=v1.24.0 and container runtime docker
./kk create cluster --with-kubernetes v1.28.6 --container-manager docker

[Notice]
Incorrect runtime. Please specify a container runtime other than Docker to install Kubernetes v1.24 or later.
You can set "spec.kubernetes.containerManager" in the configuration file to "containerd" or add "--container-manager containerd" to the "./kk create cluster" command.

K8s version >=v1.24 is able to use docker
https://github.com/kubesphere/kubekey/wiki/Upgrade-Kubernetes-cluster-from-v1.23-to-v1.24-or-later

1. change pre-check, allowed to create k8s cluster and use docker
2. install cri-docker , add cri-docker service, enable cri-docker
3. change spec.kubernetes.containerRuntimeEndpoint

after change, the result is :

./kk create cluster --with-kubernetes v1.28.6 --container-manager docker

# kubectl get node -o wide
NAME     STATUS     ROLES                  AGE     VERSION   INTERNAL-IP     EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION      CONTAINER-RUNTIME
test-2   NotReady   control-plane,worker   7m21s   v1.28.6   172.31.53.116   <none>        Ubuntu 22.04.1 LTS   5.15.0-87-generic   docker://24.0.6

Does this PR introduced a user-facing change?

Support use docker for version >= v1.24.0

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 31, 2024
@pixiake
Copy link
Collaborator

pixiake commented Feb 13, 2024

@chilianyi Thnaks for this contributions !
/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 10ef5bd003edf46bfbc54ed2343919aec6d3eba7

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chilianyi, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@ks-ci-bot ks-ci-bot merged commit 78e1124 into kubesphere:master Feb 13, 2024
4 checks passed
@pixiake
Copy link
Collaborator

pixiake commented Feb 13, 2024

@all-contributors please add @chilianyi for code

Copy link
Contributor

@pixiake

I've put up a pull request to add @chilianyi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants