Fix the issue that the cri-dockerd.sock file is not automatically deleted when stopping the cri-docker service. #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eted when stopping the cri-docker service, and when installing the cluster again, kk detects the existence of the cri-dockerd.sock file and no longer installs the cri-docker service, which in turn leads to the failure of the cluster installation.
ks-ci-bot
added
kind/bug
|
/assign @24sama |
|
@hellocn9 Thanks for this contributions ! |
|
LGTM label has been added. Git tree hash: 4ed7ab63422d69f6b2268f107a894c2c3bc97aef
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hellocn9, pixiake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue that the
/var/run/cri-dockerd.sockfile is not automatically deleted when stopping the cri-docker service, and when installing the cluster again, kk detects the existence of the/var/run/cri-dockerd.sockfile and no longer installs the cri-docker service, which in turn leads to the failure of the cluster installation.What type of PR is this?
/kind bug
What this PR does / why we need it:
When stopping the cri-docker service, the
/var/run/cri-dockerd.sockfile is not automatically deleted.When we install the cluster again, kk detects the existence of the
/var/run/cri-dockerd.sockfile and no longer installs the cri-docker service, which in turn leads to the failure of the cluster installation.Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: