Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine tasks logic #2314

Merged
merged 1 commit into from
Jul 9, 2024
Merged

refine tasks logic #2314

merged 1 commit into from
Jul 9, 2024

Conversation

pixiake
Copy link
Collaborator

@pixiake pixiake commented Jul 9, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

refine tasks logic

  • kernel config
net.ipv4.conf.all.rp_filter = 0
net.ipv4.conf.default.rp_filter = 0
  • The 'featuregate' parameter is not subject to mandatory checks.
  • Avoid repeatedly fetching initial data.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 9, 2024
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 9, 2024
Signed-off-by: pixiake <guofeng@yunify.com>
@liangzai006
Copy link
Collaborator

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 49ac730f544885e04fb0d90954bb5578d78e6ab0

@ks-ci-bot ks-ci-bot merged commit 21b8c5e into kubesphere:master Jul 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants