Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openebs): update openebs version to 2.3.0 #382

Merged
merged 5 commits into from
Nov 21, 2020

Conversation

akhilerm
Copy link
Member

  • update openebs image version to 2.3.0
  • use latest operator yaml

Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io

- update openebs image version to 2.3.0
- use latest operator yaml

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@ks-ci-bot ks-ci-bot added dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2020
@akhilerm
Copy link
Member Author

A few queries/thoughts I have:

  • images in the kubesphere registry need to be updated to point to the latest version
  • openebs images are now available as multiarch images, so pushing as multiarch into kubesphere repo will be better.
  • Only openebs localpv hostpath storage class seems to be used in kubesphere. In that case, node-disk-manager and node-disk-operator are not required. (I have not updated this in the PR. Need to discuss on it)

@akhilerm
Copy link
Member Author

/assign @Forest-L

@pixiake
Copy link
Collaborator

pixiake commented Nov 20, 2020

These images has been pushed to the kubesphere repo.

@stoneshi-yunify
Copy link
Member

@akhilerm thanks for submitting this PR. You're correct, currently kubesphere only needs openebs localpv hostpath function, it is the easiest way to provision a pv so that kubesphere can be setup and launched very quickly, ndm and ndm operator seems not needed, can you remove them from kubekey within this PR?

We're also considering adding the full pack of openebs as a addon into the kubekey addon system so that user can install the full openebs and enjoy the complete features. You're also very welcome to contributing this part of code if you'd like.

Thanks very much!

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@ks-ci-bot ks-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2020
@akhilerm
Copy link
Member Author

@pixiake . Thank you. I have one concern on the image digest. The sha256 of images in kubesphere seems to be different from the upstream images available in openebs repo. Any idea why it happened.?

@stoneshi-yunify I have removed NDM components from the PR. Only the localPV provisioner is now installed. We may need to check if this breaks any existing systems / backward compatibility.

Having the full openebs pack would be great. Let me check on the add-on system in kubekey to see how it works.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@pixiake
Copy link
Collaborator

pixiake commented Nov 20, 2020

@akhilerm
Copy link
Member Author

@pixiake. Ok got it . kubesphere is fetching the images from quay.

So, with the latest version of openebs , we are building multiarch images and pushing to docker hub. The image-{arch} are maintained in quay so as to not to break anyone during the transition to multiarch images. (NOTE: We still havent found out a reliable way to push multiarch image to different registries from our CI. So we default to dockerhub for now.)

can you check this multiarch image in docker hub. It has support for amd64, arm64, arm/v7 and power PC.

@pixiake
Copy link
Collaborator

pixiake commented Nov 20, 2020

@akhilerm
That's great, since multiarch images are already supported in docker hub, I think we can just use openebs repo.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm
Copy link
Member Author

@akhilerm
That's great, since multiarch images are already supported in docker hub, I think we can just use openebs repo.

I think the registry is specified as part of the ClusterSpec, so I dont think changes are needed in this PR for moving to openebs repo.

@pixiake
Copy link
Collaborator

pixiake commented Nov 21, 2020

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhilerm, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2020
@pixiake
Copy link
Collaborator

pixiake commented Nov 21, 2020

@akhilerm Thanks for the contribution.

@pixiake
Copy link
Collaborator

pixiake commented Nov 21, 2020

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2020
@ks-ci-bot ks-ci-bot merged commit c4fb3a1 into kubesphere:master Nov 21, 2020
@akhilerm akhilerm deleted the update-openebs-version branch November 21, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants