Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo. #813

Merged
merged 1 commit into from Nov 30, 2021
Merged

Fix typo. #813

merged 1 commit into from Nov 30, 2021

Conversation

haiker2011
Copy link
Contributor

Fix generateDOckerConfig to generateDockerConfig

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 30, 2021
@haiker2011
Copy link
Contributor Author

/assign @rayzhou2017

LinuxSuRen
LinuxSuRen approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @haiker2011 , thanks for your fixing.

@24sama
Copy link
Collaborator

24sama commented Nov 30, 2021

@haiker2011 Thanks for your contribution.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: d830a03bfdad403576530adf1d4c0d5e1185b1d4

@24sama
Copy link
Collaborator

24sama commented Nov 30, 2021

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama, haiker2011, LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@ks-ci-bot ks-ci-bot merged commit 5ed0770 into kubesphere:master Nov 30, 2021
@24sama
Copy link
Collaborator

24sama commented Nov 30, 2021

/cherrypick release-2.0

@ks-ci-bot ks-ci-bot mentioned this pull request Nov 30, 2021
Merged
@ks-ci-bot
Copy link
Collaborator

@24sama: new pull request created: #816

In response to this:

/cherrypick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen approved these changes

Assignees

@rayzhou2017 rayzhou2017

@24sama 24sama

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@haiker2011 @24sama @ks-ci-bot @LinuxSuRen @rayzhou2017