Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sed is not working in init script #836

Merged
merged 1 commit into from Dec 6, 2021
Merged

fix: sed is not working in init script #836

merged 1 commit into from Dec 6, 2021

Conversation

yjyj6
Copy link

@yjyj6 yjyj6 commented Dec 6, 2021 •
edited

What does this PR do?

Fix sed command is not working in init script.

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2021
@24sama
Copy link
Collaborator

24sama commented Dec 6, 2021 •
edited

@YJ-cloud
Thanks for your contribution! This PR is very useful to solve this issue.

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama, yj-cloud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2021
@24sama
Copy link
Collaborator

24sama commented Dec 6, 2021

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2021
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: ea404267fcf308af66adb51243c88e7a70526a44

@ks-ci-bot ks-ci-bot merged commit 4f25578 into kubesphere:master Dec 6, 2021
@24sama
Copy link
Collaborator

24sama commented Dec 6, 2021

/cherrypick release-2.0

@ks-ci-bot ks-ci-bot mentioned this pull request Dec 6, 2021
Merged
@ks-ci-bot
Copy link
Collaborator

@24sama: new pull request created: #837

In response to this:

/cherrypick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@24sama
Copy link
Collaborator

24sama commented Dec 6, 2021

@allcontributors please add @YJ-cloud for code

@allcontributors allcontributors bot mentioned this pull request Dec 6, 2021
Merged
@allcontributors
Copy link
Contributor

@24sama

I've put up a pull request to add @YJ-cloud! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@24sama 24sama 24sama approved these changes

Assignees

@24sama 24sama

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yjyj6 @24sama @ks-ci-bot