Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kk): kk recreate cluster with error #851 :get etcd local certs di… #870

Merged
merged 1 commit into from Dec 13, 2021
Merged

Conversation

tanguofu
Copy link
Contributor

this fix #851, should use InternalAddress as ETCD cluster peerAddresses

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2021
@24sama
Copy link
Collaborator

24sama commented Dec 13, 2021

Thanks for your contribution!
And definitely, you are right. That will make some errors when it is different between host address and internalAddress.

@24sama
Copy link
Collaborator

24sama commented Dec 13, 2021

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2021
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama, tanguofu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: c68eacdeb5862c9c4fd461c41ae3943183a86083

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2021
@24sama
Copy link
Collaborator

24sama commented Dec 13, 2021

/cherrypick release-2.0

@ks-ci-bot
Copy link
Collaborator

@24sama: once the present PR merges, I will cherry-pick it on top of release-2.0 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot
Copy link
Collaborator

@24sama: new pull request created: #871

In response to this:

/cherrypick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get etcd local certs dir by module cache failed when recreate cluster with kk v2.0.0-version(master)
3 participants