Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update kk upgrade parameters #909

Merged
merged 2 commits into from Dec 21, 2021
Merged

docs: Update kk upgrade parameters #909

merged 2 commits into from Dec 21, 2021

Conversation

lvillis
Copy link
Contributor

@lvillis lvillis commented Dec 20, 2021

No description provided.

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2021
@lvillis
Copy link
Contributor Author

lvillis commented Dec 20, 2021

/assign @24sama

@24sama
Copy link
Collaborator

24sama commented Dec 20, 2021

Thanks for your contribution.

Could you please also modify these error full name parameters?

@ks-ci-bot ks-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2021
@lvillis
Copy link
Contributor Author

lvillis commented Dec 20, 2021

Thanks for your contribution.

Could you please also modify these error full name parameters?

Now all "--file" parameters have been updated to "--filename"

@lvillis
Copy link
Contributor Author

lvillis commented Dec 21, 2021

/assign @24sama

@24sama
Copy link
Collaborator

24sama commented Dec 21, 2021

Thanks for your contribution.
Could you please also modify these error full name parameters?

Now all "--file" parameters have been updated to "--filename"

Thanks.

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2021
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 5a37af98cc3f7381c9cee72b9eb3d22195e830d6

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama, lvillis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2021
@ks-ci-bot ks-ci-bot merged commit 2fb0649 into kubesphere:master Dec 21, 2021
@24sama
Copy link
Collaborator

24sama commented Dec 21, 2021

@allcontributors please add @lvillis for doc

@allcontributors allcontributors bot mentioned this pull request Dec 21, 2021
Merged
@allcontributors
Copy link
Contributor

@24sama

I've put up a pull request to add @lvillis! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@24sama 24sama

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lvillis @24sama @ks-ci-bot