Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify manifest's containerRuntime to a list #941

Merged
merged 1 commit into from Dec 28, 2021

Conversation

24sama
Copy link
Collaborator

@24sama 24sama commented Dec 28, 2021

What does this PR do?

Modify manifest's containerRuntime to a list. And it will make kk can detect and show multi-container runtimes from the cluster.

Signed-off-by: 24sama <leo@kubesphere.io>
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2021
@24sama
Copy link
Collaborator Author

24sama commented Dec 28, 2021

/cc @pixiake

@ks-ci-bot ks-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 28, 2021
@pixiake
Copy link
Collaborator

pixiake commented Dec 28, 2021

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 28, 2021
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 7afc8d35b0aa2d970de9f0f47c96eefe8365dad6

@ks-ci-bot ks-ci-bot merged commit 0b9d781 into kubesphere:master Dec 28, 2021
@24sama
Copy link
Collaborator Author

24sama commented Jan 10, 2022

/cherrypick release-2.0

@ks-ci-bot
Copy link
Collaborator

@24sama: new pull request created: #969

In response to this:

/cherrypick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants