Support kubekey to independently generate certificates #944
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pixiake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
approved
pkg/etcd/certs.go
Outdated
| func (f *FetchCerts) Execute(runtime connector.Runtime) error { | ||
| src := "/etc/ssl/etcd/ssl" | ||
| dst := fmt.Sprintf("%s/pki/etcd", runtime.GetWorkDir()) | ||
| if v, ok := f.PipelineCache.Get(common.ETCDCluster); ok { |
There was a problem hiding this comment.
Maybe we handle !ok first will make code indentation more graceful. For example:
| if v, ok := f.PipelineCache.Get(common.ETCDCluster); ok { | |
| v, ok := f.PipelineCache.Get(common.ETCDCluster) | |
| if !ok { | |
| return errors.New("get etcd status from pipeline cache failed") | |
| } |
| @@ -0,0 +1,320 @@ | |||
| /* | |||
| Copyright 2016 The Kubernetes Authors. | |||
There was a problem hiding this comment.
Does the copyright need to be modified?
There was a problem hiding this comment.
The code in this file is obtained from kubernetes. So the copyright needs to be consistent with kubernetes.
There was a problem hiding this comment.
So, is it normal for a project to have two different copyright?
Signed-off-by: pixiake <guofeng@yunify.com>
|
/lgtm |
|
LGTM label has been added. Git tree hash: 7cb21d048923875d187c4b6d957014992d76ba05
|
|
/cherrypick release-2.0 |
|
@24sama: new pull request created: #971 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What does this PR do ？
Signed-off-by: pixiake guofeng@yunify.com