Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tower server shouldn't update the cluster.status #3234

Closed
swiftslee opened this issue Dec 30, 2020 · 8 comments · Fixed by kubesphere/tower#34 or #3380
Closed

The tower server shouldn't update the cluster.status #3234

swiftslee opened this issue Dec 30, 2020 · 8 comments · Fixed by kubesphere/tower#34 or #3380
Assignees
Labels
area/multicluster Issues or PRs related to multi-cluster. kind/feature-request Request a feature
Milestone

Comments

@swiftslee
Copy link
Contributor

What's it about?
Currently, when cluster.spec.connection.type is proxy, the tower server updates the cluster.status filed, and the cluster controller determines if the cluster is ready according to the status.

What's the reason why we need it?
Actually, the tower server shouldn't update the cluster.status filed.
The cluster controller can try to connect to the proxy service, determines if the cluster is ready by the response HTTP code.
This proposal can reduce the complexity between tower server and clsuter-controller.
/area multicluster
/kind feature-request

@ks-ci-bot ks-ci-bot added area/multicluster Issues or PRs related to multi-cluster. kind/feature-request Request a feature labels Dec 30, 2020
@lxm
Copy link
Member

lxm commented Dec 31, 2020

kubernetesAPIEndpoint
kubernetesAPIServerPort
kubesphereAPIEndpoint
kubesphereAPIServerPort

It may be a good choice to manage the above fields in tower

@calvinyv
Copy link
Member

/assign @yuswift pls take a look

@ks-ci-bot
Copy link
Collaborator

@calvinyv: GitHub didn't allow me to assign the following users: pls, take, a, look.

Note that only kubesphere members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @yuswift pls take a look

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lxm
Copy link
Member

lxm commented Dec 31, 2020

On the other hand, the creation of the service mc-xxxx is best placed in the tower

@swiftslee
Copy link
Contributor Author

kubernetesAPIEndpoint
kubernetesAPIServerPort
kubesphereAPIEndpoint
kubesphereAPIServerPort

It may be a good choice to manage the above fields in tower

LGTM. @zryfish

@zryfish
Copy link
Member

zryfish commented Jan 4, 2021

yeah, agreed

@swiftslee
Copy link
Contributor Author

/milestone 3.1.0

@ks-ci-bot ks-ci-bot added this to the 3.1.0 milestone Jan 6, 2021
@zryfish
Copy link
Member

zryfish commented Feb 19, 2021

@yuswift Any update on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/multicluster Issues or PRs related to multi-cluster. kind/feature-request Request a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants