Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workload auto-restart function when pvc expanded #4090

Closed
stoneshi-yunify opened this issue Jul 21, 2021 · 6 comments · Fixed by #4121
Closed

Remove workload auto-restart function when pvc expanded #4090

stoneshi-yunify opened this issue Jul 21, 2021 · 6 comments · Fixed by #4121
Assignees
Labels
area/storage good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@stoneshi-yunify
Copy link
Member

Describe the Bug
Need to remove the controller function in kubesphere/pkg/controller/storage/expansion

We can not stop a workload (by scaling down to replicas=0) without user's confirmation, because it may interrupt user's application and affect user's business. And current function can only handle deployments/statefulsets, so it's incomplete.

And there are some storage supporting online filesystem expansion that doesn't require pod restart.

Versions Used
KubeSphere: v3.1.1 and before
Kubernetes: (If KubeSphere installer used, you can skip this)

/kind bug
/area storage
/milestone v3.2
/good-first-issue

@ks-ci-bot
Copy link
Collaborator

@stoneshi-yunify:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Describe the Bug
Need to remove the controller function in kubesphere/pkg/controller/storage/expansion

We can not stop a workload (by scaling down to replicas=0) without user's confirmation, because it may interrupt user's application and affect user's business. And current function can only handle deployments/statefulsets, so it's incomplete.

And there are some storage supporting online filesystem expansion that doesn't require pod restart.

Versions Used
KubeSphere: v3.1.1 and before
Kubernetes: (If KubeSphere installer used, you can skip this)

/kind bug
/area storage
/milestone v3.2
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 21, 2021
@ks-ci-bot ks-ci-bot added this to the v3.2 milestone Jul 21, 2021
@ks-ci-bot ks-ci-bot added area/storage good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 21, 2021
@stoneshi-yunify stoneshi-yunify removed this from the v3.2 milestone Jul 21, 2021
@wenhuwang
Copy link
Contributor

@stoneshi-yunify Does the removal of the workload automatic restart function require compatibility with some storage that does not support hot expansion, or for this situation to allow the user to manually restart.

@stoneshi-yunify
Copy link
Member Author

@stoneshi-yunify Does the removal of the workload automatic restart function require compatibility with some storage that does not support hot expansion, or for this situation to allow the user to manually restart.

Yes, user needs to decide when to restart the workload and restart it manually.

@wenhuwang
Copy link
Contributor

@stoneshi-yunify Does the removal of the workload automatic restart function require compatibility with some storage that does not support hot expansion, or for this situation to allow the user to manually restart.

Yes, user needs to decide when to restart the workload and restart it manually.

So we need to remove storage expansion controller?i have confirmed that the expansion controller is mainly to restart the workload.

@stoneshi-yunify
Copy link
Member Author

@stoneshi-yunify Does the removal of the workload automatic restart function require compatibility with some storage that does not support hot expansion, or for this situation to allow the user to manually restart.

Yes, user needs to decide when to restart the workload and restart it manually.

So we need to remove storage expansion controller?i have confirmed that the expansion controller is mainly to restart the workload.

Yes, simply remove the storage expansion controller will resolve this issue.

@wenhuwang
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants