New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workload auto-restart function when pvc expanded #4090
Comments
@stoneshi-yunify: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@stoneshi-yunify Does the removal of the workload automatic restart function require compatibility with some storage that does not support hot expansion, or for this situation to allow the user to manually restart. |
Yes, user needs to decide when to restart the workload and restart it manually. |
So we need to remove storage expansion controller?i have confirmed that the expansion controller is mainly to restart the workload. |
Yes, simply remove the storage expansion controller will resolve this issue. |
/assign |
Describe the Bug
Need to remove the controller function in kubesphere/pkg/controller/storage/expansion
We can not stop a workload (by scaling down to replicas=0) without user's confirmation, because it may interrupt user's application and affect user's business. And current function can only handle deployments/statefulsets, so it's incomplete.
And there are some storage supporting online filesystem expansion that doesn't require pod restart.
Versions Used
KubeSphere: v3.1.1 and before
Kubernetes: (If KubeSphere installer used, you can skip this)
/kind bug
/area storage
/milestone v3.2
/good-first-issue
The text was updated successfully, but these errors were encountered: