Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support discover tags for multi-branch pipeline #3125

Merged
merged 2 commits into from Nov 24, 2020

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented Nov 17, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add support tag discover for multi-branch pipeline

Which issue(s) this PR fixes:
Fixes #3051

Special notes for reviewers:

Additional documentation, usage docs, etc.:

@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 17, 2020
@LinuxSuRen
Copy link
Member Author

/area devops

@LinuxSuRen LinuxSuRen force-pushed the discover-tag-support branch 3 times, most recently from 938af80 to 098e8a7 Compare November 17, 2020 08:01
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #3125 (f81486c) into master (e9f7090) will increase coverage by 0.10%.
The diff coverage is 24.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3125      +/-   ##
==========================================
+ Coverage   10.87%   10.98%   +0.10%     
==========================================
  Files         204      204              
  Lines       40347    40287      -60     
==========================================
+ Hits         4389     4426      +37     
+ Misses      35304    35194     -110     
- Partials      654      667      +13     
Flag Coverage Δ
unittests 10.98% <24.13%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apis/devops/v1alpha3/pipeline_types.go 100.00% <ø> (ø)
pkg/apis/devops/v1alpha3/zz_generated.deepcopy.go 7.08% <ø> (-0.56%) ⬇️
pkg/controller/cluster/cluster_controller.go 0.00% <0.00%> (ø)
pkg/controller/namespace/namespace_controller.go 0.00% <0.00%> (ø)
pkg/models/registries/blob.go 0.00% <0.00%> (ø)
pkg/models/registries/manifest.go 56.52% <0.00%> (ø)
.../simple/client/devops/jenkins/pipeline_internal.go 79.32% <20.00%> (-1.41%) ⬇️
.../simple/client/monitoring/prometheus/prometheus.go 83.01% <60.00%> (ø)
pkg/controller/pipeline/pipeline_controller.go 38.01% <100.00%> (-3.16%) ⬇️
pkg/models/monitoring/expressions/prometheus.go 83.33% <100.00%> (+36.06%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9f7090...cec7793. Read the comment docs.

@LinuxSuRen
Copy link
Member Author

/cc shaowenchen

Signed-off-by: rick <rick@jenkins-zh.cn>
Signed-off-by: rick <rick@jenkins-zh.cn>
@shaowenchen
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@zryfish
Copy link
Member

zryfish commented Nov 24, 2020

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, zryfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2020
@ks-ci-bot ks-ci-bot merged commit 5a816f7 into kubesphere:master Nov 24, 2020
@LinuxSuRen LinuxSuRen deleted the discover-tag-support branch November 24, 2020 05:35
@weekyuan
Copy link

How can I experience this new feature on 3.0?

@LinuxSuRen
Copy link
Member Author

LinuxSuRen commented Dec 15, 2020

hi @weekyuan, of course. Welcome! But please make sure DO NOT test it in any official environment yet. I highly suggest that you test it in a personal or temporary environment. Because it has not been released yet.

OK. I guess you're all ready to go. Let's rock it. There're four components you need to update:

  • ks-apiserver --> kubespheredev/ks-apiserver
  • ks-controller-manager --> kubespheredev/ks-controller-manager
  • ks-console --> kubespheredev/ks-console
  • ks-jenkins --> kubespheredev/ks-jenkins:2.249.1

After you updated these deployments with the latest container images. You can create a multi-branch pipeline with Gitlab. But there's still a couple of things you might need to know.

Restriction

@LinuxSuRen
Copy link
Member Author

Hi @weekyuan. Sorry for misleading you about this. It looks like the front-end is not ready. Please follow kubesphere/console#1310

@weekyuan
Copy link

Hi @weekyuan. Sorry for misleading you about this. It looks like the front-end is not ready. Please follow kubesphere/console#1310

okay,Thank you for your help!

@shaowenchen shaowenchen added this to Done in devops Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

feature: support tag trigger pipeline
5 participants