Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devops artifact cannot be download due to auth checking #3190

Merged
merged 1 commit into from Dec 10, 2020

Conversation

LinuxSuRen
Copy link
Member

What type of PR is this?
/kind bug
/area devops

What this PR does / why we need it:
This PR can fix that artifacts from pipeline cannot be download.

Which issue(s) this PR fixes:
Fixes #3083

Special notes for reviewers:
I suggest that the front-end should replace API call from /jenkins/{path:*} to /devops/{devops}/jenkins/{path:*}

Additional documentation, usage docs, etc.:

@ks-ci-bot ks-ci-bot added kind/bug Categorizes issue or PR as related to a bug. area/devops dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2020
@LinuxSuRen
Copy link
Member Author

/cc @shaowenchen
/cc @harrisonliu5

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #3190 (c9ae919) into master (dab0842) will increase coverage by 0.14%.
The diff coverage is 23.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3190      +/-   ##
==========================================
+ Coverage   11.19%   11.33%   +0.14%     
==========================================
  Files         209      209              
  Lines       40581    40654      +73     
==========================================
+ Hits         4543     4610      +67     
+ Misses      35357    35352       -5     
- Partials      681      692      +11     
Flag Coverage Δ
unittests 11.33% <23.65%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/apiserver/authentication/oauth/oauth_options.go 56.66% <ø> (ø)
...apiserver/authorization/rbac/evaluation_helpers.go 15.49% <ø> (ø)
pkg/controller/user/user_webhook.go 0.00% <0.00%> (ø)
pkg/kapis/monitoring/v1alpha3/register.go 0.00% <0.00%> (ø)
pkg/kapis/resources/v1alpha3/register.go 0.00% <0.00%> (ø)
pkg/models/auth/login_recoder.go 0.00% <0.00%> (ø)
pkg/models/auth/token.go 0.00% <ø> (ø)
pkg/models/iam/im/im.go 0.00% <0.00%> (-2.78%) ⬇️
pkg/models/auth/authenticator.go 0.95% <0.95%> (ø)
...hentication/identityprovider/ldap/ldap_provider.go 8.57% <15.38%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab0842...4d9268b. Read the comment docs.

@shaowenchen
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
Signed-off-by: rick <rick@jenkins-zh.cn>
@ks-ci-bot ks-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@zryfish
Copy link
Member

zryfish commented Dec 10, 2020

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, zryfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2020
@ks-ci-bot ks-ci-bot merged commit cdc03e7 into kubesphere:master Dec 10, 2020
@LinuxSuRen LinuxSuRen deleted the fix/artifact-download-er branch December 10, 2020 13:53
@shaowenchen shaowenchen added this to Done in devops Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

DevOps Project admin cannot download artifacts
4 participants