Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support workspace resource quota #3310

Closed
wants to merge 1 commit into from

Conversation

wansir
Copy link
Member

@wansir wansir commented Jan 27, 2021

Signed-off-by: hongming talonwan@yunify.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

resourcequotas.quota.kubesphere.io mirrors ResourceQuota at a cluster scope. This object is easily convertible to synthetic ResourceQuota object to allow quota evaluation re-use.

Which issue(s) this PR fixes:

Related to #2939

Special notes for reviewers:

Add resourcequotas.quota.kubesphere.io CRD.
Add resourcesquotas.quota.kubesphere.io ValidatingWebhookConfiguration.

Additional documentation, usage docs, etc.:

The cluster scope resource quota can be used in the workspace, all namespaces in the workspace are affected by the workspace resource quota.

image

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wansir
To complete the pull request process, please assign zryfish
You can assign the PR to them by writing /assign @zryfish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 27, 2021
@wansir wansir force-pushed the ws-resource-quota branch 4 times, most recently from 8759a14 to 8bb2476 Compare January 28, 2021 04:28
@shaowenchen
Copy link
Contributor

It should be placed in a new branch, not merged into release-3.0. This is a big change.

@wansir wansir force-pushed the ws-resource-quota branch 2 times, most recently from 29a5224 to 40ecc1a Compare January 29, 2021 04:26
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #3310 (759f3f8) into release-3.0 (e8505c1) will decrease coverage by 0.83%.
The diff coverage is 17.02%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-3.0   #3310      +/-   ##
==============================================
- Coverage        10.72%   9.89%   -0.84%     
==============================================
  Files              194     198       +4     
  Lines            41988   38978    -3010     
==============================================
- Hits              4504    3857     -647     
+ Misses           36909   34561    -2348     
+ Partials           575     560      -15     
Flag Coverage Δ
unittests 9.89% <17.02%> (-0.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apis/quota/v1alpha2/register.go 0.00% <0.00%> (ø)
pkg/models/tenant/resourcequota.go 0.00% <0.00%> (ø)
pkg/models/tenant/tenant.go 14.54% <ø> (-0.93%) ⬇️
pkg/apis/quota/v1alpha2/zz_generated.deepcopy.go 23.07% <23.07%> (ø)
pkg/apis/quota/v1alpha2/types.go 100.00% <100.00%> (ø)
pkg/db/condition.go 40.74% <0.00%> (-9.26%) ⬇️
pkg/simple/client/mysql/condition.go 40.74% <0.00%> (-9.26%) ⬇️
.../models/resources/v1alpha3/configmap/configmaps.go 52.63% <0.00%> (-7.37%) ⬇️
...esources/v1alpha3/networkpolicy/networkpolicies.go 52.63% <0.00%> (-7.37%) ⬇️
pkg/models/resources/v1alpha3/service/services.go 36.84% <0.00%> (-7.16%) ⬇️
... and 192 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8505c1...759f3f8. Read the comment docs.

@wansir wansir force-pushed the ws-resource-quota branch 3 times, most recently from ae2c010 to 9d6e9d5 Compare January 30, 2021 12:42
Signed-off-by: hongming <talonwan@yunify.com>
@wansir
Copy link
Member Author

wansir commented Feb 2, 2021

Related to #3344

/close

@ks-ci-bot ks-ci-bot closed this Feb 2, 2021
@ks-ci-bot
Copy link
Collaborator

@wansir: Closed this PR.

In response to this:

Related to #3344

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wansir wansir deleted the ws-resource-quota branch September 16, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants