Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support query pods by status #4434

Merged
merged 1 commit into from Nov 11, 2021
Merged

Support query pods by status #4434

merged 1 commit into from Nov 11, 2021

Conversation

iawia002
Copy link
Member

@iawia002 iawia002 commented Nov 11, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds status filtering to the kapis/resources.kubesphere.io/v1alpha3/pods API, which now allows you to filter pods with a specific status by the status query parameter, eg:

/kapis/resources.kubesphere.io/v1alpha3/pods?sortBy=startTime&limit=10&status=Running

Which issue(s) this PR fixes:

Fixes #

Does this PR introduced a user-facing change?

Support query pods by status.

/cc @zryfish

@ks-ci-bot ks-ci-bot added release-note kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 11, 2021
@ks-ci-bot ks-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 11, 2021
@zryfish
Copy link
Member

zryfish commented Nov 11, 2021

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2021
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 7f356c052f83d0d4f71cb56f00382b5ae7e06db7

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iawia002, zryfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2021
@ks-ci-bot ks-ci-bot merged commit 8a0403e into kubesphere:master Nov 11, 2021
@iawia002 iawia002 deleted the query branch November 11, 2021 08:25
@iawia002
Copy link
Member Author

@zryfish Do we need to cherry-pick this to the release-3.2 branch?

@zryfish
Copy link
Member

zryfish commented Nov 11, 2021

Yeah, go ahead. just comment with /cherrypick [branch name]

@iawia002
Copy link
Member Author

/cherrypick release-3.2

@ks-ci-bot
Copy link
Collaborator

@iawia002: new pull request created: #4438

In response to this:

/cherrypick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants