Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golangci-lint workflow #4999

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Add golangci-lint workflow #4999

merged 3 commits into from
Jun 29, 2022

Conversation

xyz-li
Copy link
Contributor

@xyz-li xyz-li commented Jun 27, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add golangci-lint workflow to check code.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 27, 2022
@xyz-li
Copy link
Contributor Author

xyz-li commented Jun 27, 2022

/test all

@xyz-li xyz-li changed the title WIP: Add golangci-lint workflow Add golangci-lint workflow Jun 27, 2022
@ks-ci-bot ks-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2022
@xyz-li
Copy link
Contributor Author

xyz-li commented Jun 27, 2022

/cc @wansir
/cc @zheng1

@ks-ci-bot ks-ci-bot requested review from wansir and zheng1 June 27, 2022 06:01
@xyz-li xyz-li force-pushed the golint branch 3 times, most recently from 7916d75 to 1d0a531 Compare June 27, 2022 07:19
@xyz-li
Copy link
Contributor Author

xyz-li commented Jun 27, 2022

/test pull-kubesphere-verify

@xyz-li
Copy link
Contributor Author

xyz-li commented Jun 28, 2022

/cc @LinuxSuRen

@wansir
Copy link
Member

wansir commented Jun 29, 2022

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 9a6509e8b6840b0deaed5f4e90e30bc97c7c66ab

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wansir, xyz-li

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2022
@ks-ci-bot ks-ci-bot merged commit f289795 into kubesphere:master Jun 29, 2022
sologgfun pushed a commit to sologgfun/kubesphere that referenced this pull request Apr 24, 2023
* fix lint workflow

* add golang lint

* close http response body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants