Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go version to 1.18 #5045

Merged
merged 5 commits into from
Jul 18, 2022
Merged

Upgrade go version to 1.18 #5045

merged 5 commits into from
Jul 18, 2022

Conversation

wansir
Copy link
Member

@wansir wansir commented Jul 8, 2022

What type of PR is this?

Upgrade go version to 1.18.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wansir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase labels Jul 8, 2022
@wansir
Copy link
Member Author

wansir commented Jul 13, 2022

/retest

@wansir
Copy link
Member Author

wansir commented Jul 15, 2022

/retest

@wansir
Copy link
Member Author

wansir commented Jul 15, 2022

/cc @xyz-li @iawia002 @zheng1

@wansir
Copy link
Member Author

wansir commented Jul 15, 2022

/test pull-kubesphere-verify

@xyz-li
Copy link
Contributor

xyz-li commented Jul 18, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 3f21282546d229953e21c61de55592f42fb7ba97

@ks-ci-bot ks-ci-bot merged commit 521cb40 into kubesphere:master Jul 18, 2022
sologgfun pushed a commit to sologgfun/kubesphere that referenced this pull request Apr 24, 2023
* Upgrade go version to 1.18

* fix go 1.18 compatibility

* update gofmt

* ignore golangci-lint staticcheck

* update gofmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants