Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rulegroup definitions for different scopes #5064

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

junotx
Copy link
Contributor

@junotx junotx commented Jul 15, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Define the following CRDs:

  • RuleGroup: its instances take effect in its namespace
  • ClusterRuleGroup: its instances take effect in its cluster
  • GlobalRuleGroup: its instances take effect for all clusters

They will be used to provide easier alerting rule operations.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

Introduce CRDs to define alerting rules with defferent scopes for easier alerting rule operations

Additional documentation, usage docs, etc.:


Signed-off-by: junot <junotxiang@kubesphere.io>
@ks-ci-bot ks-ci-bot added release-note kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 15, 2022
@junotx junotx requested a review from benjaminhuo July 15, 2022 08:59
@benjaminhuo
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: ba359a1d595dcb283fcd5d19acb32b9732440b7c

@benjaminhuo
Copy link
Member

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminhuo, junotx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2022
@benjaminhuo
Copy link
Member

/retest

@wansir
Copy link
Member

wansir commented Jul 15, 2022

/hold

The go version used in build-tools has been upgraded to 1.18.4, which will cause the ci job to fail.

@ks-ci-bot
Copy link
Collaborator

@junotx: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubesphere-verify 91a525c link /test pull-kubesphere-verify
pull-kubesphere-unit-test 91a525c link /test pull-kubesphere-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@benjaminhuo
Copy link
Member

/hold

The go version used in build-tools has been upgraded to 1.18.4, which will cause the ci job to fail.

reverting go version to 1.17 for build-tools will fix this? @wansir

@benjaminhuo benjaminhuo merged commit e529703 into kubesphere:master Jul 18, 2022
@junotx junotx deleted the rulegroups branch July 20, 2022 02:16
zhou1203 pushed a commit that referenced this pull request Oct 15, 2022
Signed-off-by: junot <junotxiang@kubesphere.io>
sologgfun pushed a commit to sologgfun/kubesphere that referenced this pull request Apr 24, 2023
Signed-off-by: junot <junotxiang@kubesphere.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants