Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golint with new commit #5074

Merged
merged 1 commit into from
Jul 20, 2022
Merged

golint with new commit #5074

merged 1 commit into from
Jul 20, 2022

Conversation

xyz-li
Copy link
Contributor

@xyz-li xyz-li commented Jul 19, 2022

What type of PR is this?

/kind flake

What this PR does / why we need it:

go lint with origin/master, shows only new issues created with new commit.

Which issue(s) this PR fixes:

Fixes #5063

Special notes for reviewers:

Does this PR introduced a user-facing change?

NONE

Additional documentation, usage docs, etc.:


/cc @wansir

@ks-ci-bot ks-ci-bot requested a review from wansir July 19, 2022 07:25
@ks-ci-bot ks-ci-bot added release-note-none kind/flake Categorizes issue or PR as related to a flaky test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2022
@ks-ci-bot ks-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2022
@wansir
Copy link
Member

wansir commented Jul 20, 2022

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 92aab196805cfa5da72238fc951d832316f5b935

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wansir, xyz-li

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2022
@ks-ci-bot ks-ci-bot merged commit 77b1085 into kubesphere:master Jul 20, 2022
sologgfun pushed a commit to sologgfun/kubesphere that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup CI to run golangci-lint with option --new-from-rev
3 participants