Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Gateway supports the configuration of forwarding tcp/udp traffic. #5445

Merged
merged 1 commit into from Jan 11, 2023

Conversation

hongzhouzi
Copy link
Member

@hongzhouzi hongzhouzi commented Jan 6, 2023

Signed-off-by: hongzhouzi hongzhouzi@kubesphere.io

What type of PR is this?

/kind feature

What this PR does / why we need it:

Gateway supports the configuration of forwarding tcp/udp traffic.

Which issue(s) this PR fixes:

Fixes # #5406

Special notes for reviewers:

Add tcp/udp two configuration items below the configuration options on the gateway edit page, and add tcp/udp configuration in the following format when create and update a Gateway CR.

Configure key-value pairs in tcp/udp configuration, the key is the external port to use and the value indicates the service to expose using the format: <namespace/service name>:<service port>:[PROXY]:[PROXY]
Reference: https://kubernetes.github.io/ingress-nginx/user-guide/exposing-tcp-udp-services/

apiVersion: gateway.kubesphere.io/v1alpha1
kind: Gateway
metadata: {}
spec:
  controller:
    tcp:
      '8080': 'default/example-tcp-svc1:9000'
      '8081': 'default/example-tcp-svc2:9001'
    udp:
      '53': 'kube-system/coredns:53'

Does this PR introduced a user-facing change?

Gateway supports the configuration of forwarding tcp/udp traffic.

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added release-note kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2023
@hongzhouzi
Copy link
Member Author

/cc @wansir @iawia002

Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io>
@iawia002
Copy link
Member

iawia002 commented Jan 6, 2023

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 146df6eb8c563744470bcc5fbb22dd82485db02e

@hongzhouzi
Copy link
Member Author

/cc @harrisonliu5
Can you add this part of the operation and the parameters passed on the front-end page? Both the cluster gateway and the project gateway need to be added.

Add tcp/udp two configuration items below the configuration options on the gateway edit page, and add tcp/udp configuration in the following format when create and update a Gateway CR.

Configure key-value pairs in tcp/udp configuration, the key is the external port to use and the value indicates the service to expose using the format: <namespace/service name>:<service port>:[PROXY]:[PROXY] Reference: https://kubernetes.github.io/ingress-nginx/user-guide/exposing-tcp-udp-services/

apiVersion: gateway.kubesphere.io/v1alpha1
kind: Gateway
metadata: {}
spec:
  controller:
    tcp:
      '8080': 'default/example-tcp-svc1:9000'
      '8081': 'default/example-tcp-svc2:9001'
    udp:
      '53': 'kube-system/coredns:53'

@wansir
Copy link
Member

wansir commented Jan 11, 2023

/lgtm
/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongzhouzi, wansir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023
@ks-ci-bot ks-ci-bot merged commit 3a03b4a into kubesphere:master Jan 11, 2023
sologgfun pushed a commit to sologgfun/kubesphere that referenced this pull request Apr 24, 2023
…c. (kubesphere#5445)

Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io>

Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io>
wanjunlei pushed a commit to wanjunlei/kubesphere that referenced this pull request Aug 11, 2023
…c. (kubesphere#5445)

Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io>

Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants