Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved Conflict [release-3.3] Fix failed to cache resources if group version not found #5408 #5466

Conversation

hongzhouzi
Copy link
Member

Signed-off-by: hongzhouzi hongzhouzi@kubesphere.io

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

Replaces this PR #5408 merged in release-3.3, and it also depends on part of the code of this PR #5101

Which issue(s) this PR fixes:

Fixes # #5460

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


…p version not found kubesphere#5408

Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io>
@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2023
@hongzhouzi
Copy link
Member Author

/cc @wansir

@ks-ci-bot ks-ci-bot requested a review from wansir January 12, 2023 10:28
@wansir
Copy link
Member

wansir commented Jan 12, 2023

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 3149db0acaed21eabc8866d2f97994899b1ac723

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongzhouzi, wansir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@ks-ci-bot ks-ci-bot merged commit dbb3f04 into kubesphere:release-3.3 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants