Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the issue that the upload app template did not display icons #5467

Merged
merged 5 commits into from Jan 29, 2023

Conversation

liangzai006
Copy link
Contributor

What type of PR is this?

/king bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
https://github.com/kubesphere/issues/issues/669

Special notes for reviewers:

Does this PR introduced a user-facing change?

1、fix the issue that the upload app template did not display icons

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2023
@wansir wansir requested a review from isyes January 13, 2023 07:35
@wansir
Copy link
Member

wansir commented Jan 13, 2023

/lgtm
/approve

/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@wansir: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/lgtm
/approve

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 3687f3e646a14c092ab32a816f6562308ba06256

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2023
@wansir
Copy link
Member

wansir commented Jan 13, 2023

/retest

@wansir wansir self-requested a review January 29, 2023 02:07
@wansir wansir merged commit 2972cb9 into kubesphere:master Jan 29, 2023
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangzai006, wansir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot
Copy link
Collaborator

@wansir: new pull request created: #5493

In response to this:

/lgtm
/approve

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sologgfun pushed a commit to sologgfun/kubesphere that referenced this pull request Apr 24, 2023
…esphere#5467)

* fix appstore app home field

* fix the issue that the upload app template did not display icons
wanjunlei pushed a commit to wanjunlei/kubesphere that referenced this pull request Aug 11, 2023
…esphere#5467)

* fix appstore app home field

* fix the issue that the upload app template did not display icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants