Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot get registered resource #5515

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

zhou1203
Copy link
Member

@zhou1203 zhou1203 commented Feb 10, 2023

Signed-off-by: wenhaozhou wenhaozhou@yunify.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

Fix cannot get registered resource

Additional documentation, usage docs, etc.:


Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
@ks-ci-bot ks-ci-bot added release-note kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2023
@zhou1203
Copy link
Member Author

/cc @wansir

@gewei2000
Copy link

gewei2000 commented Feb 13, 2023

lgtm @wansir

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 54a7c37ad4eee68e5ba875fd04afc26752f12a6d

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
@ks-ci-bot ks-ci-bot added release-note and removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none labels Feb 15, 2023
@wansir
Copy link
Member

wansir commented Feb 15, 2023

/unhold

@wansir
Copy link
Member

wansir commented Feb 15, 2023

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 333f65524aa3eebc6a3db5227bcea873c547edf6

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wansir, zhou1203

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
@ks-ci-bot ks-ci-bot merged commit b143b41 into kubesphere:master Feb 15, 2023
@zhou1203 zhou1203 deleted the resources-bugfix branch March 21, 2023 09:33
sologgfun pushed a commit to sologgfun/kubesphere that referenced this pull request Apr 24, 2023
* Fix can`t get registered resource

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update v1beta1 interface Get func`s parameters

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

---------

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
wanjunlei pushed a commit to wanjunlei/kubesphere that referenced this pull request Aug 11, 2023
* Fix can`t get registered resource

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update v1beta1 interface Get func`s parameters

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

---------

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
zhou1203 added a commit to zhou1203/kubesphere that referenced this pull request Jan 24, 2024
* Fix can`t get registered resource

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update v1beta1 interface Get func`s parameters

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

---------

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
(cherry picked from commit b143b41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants