Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api for identity provider login #5534

Merged
merged 7 commits into from Feb 27, 2023

Conversation

zhou1203
Copy link
Member

@zhou1203 zhou1203 commented Feb 17, 2023

What type of PR is this?

/kind api-change

What this PR does / why we need it:

A new API for identityProviders login will be added.

Which issue(s) this PR fixes:

fix: https://github.com/kubesphere/issues/issues/58

Special notes for reviewers:

Does this PR introduced a user-facing change?

Remove deprecated auth API, and add new auth API for identity providers.

Additional documentation, usage docs, etc.:

Post "/oauth/login/{identityprovider}"
Form username=xxx password=xxx

@ks-ci-bot ks-ci-bot added release-note kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Feb 17, 2023
@zhou1203 zhou1203 requested a review from wansir February 17, 2023 11:10
@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 17, 2023
pkg/kapis/oauth/register.go Outdated Show resolved Hide resolved
…type

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
@zhou1203 zhou1203 requested a review from wansir February 20, 2023 08:39
Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
@ks-ci-bot ks-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 24, 2023
Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
@zhou1203 zhou1203 changed the title Add api for ldap login Add api for identity provider login Feb 24, 2023
Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
@wansir
Copy link
Member

wansir commented Feb 27, 2023

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: f72fe54dafc68b8d55fa9a9e462b17111fea9718

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wansir, zhou1203

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@ks-ci-bot ks-ci-bot merged commit dc28a09 into kubesphere:master Feb 27, 2023
sekfung pushed a commit to sekfung/kubesphere that referenced this pull request Mar 2, 2023
* add api for ldap login

* update ldap login to identity provider login for more flexible login type

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update PasswordAuthenticate

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* add test case

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update api path

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* make goimports and add annotations

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update func names & add annotations

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

---------

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
@zhou1203 zhou1203 deleted the feature-ldap-login branch March 21, 2023 09:33
sologgfun pushed a commit to sologgfun/kubesphere that referenced this pull request Apr 24, 2023
* add api for ldap login

* update ldap login to identity provider login for more flexible login type

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update PasswordAuthenticate

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* add test case

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update api path

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* make goimports and add annotations

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update func names & add annotations

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

---------

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
@wansir wansir mentioned this pull request Aug 1, 2023
wanjunlei pushed a commit to wanjunlei/kubesphere that referenced this pull request Aug 11, 2023
* add api for ldap login

* update ldap login to identity provider login for more flexible login type

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update PasswordAuthenticate

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* add test case

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update api path

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* make goimports and add annotations

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update func names & add annotations

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

---------

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants