Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #5018 #5548

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Revert PR #5018 #5548

merged 1 commit into from
Feb 27, 2023

Conversation

zhou1203
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #5547

Special notes for reviewers:

Does this PR introduced a user-facing change?

Revert the PR #5018

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added release-note kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2023
@zhou1203 zhou1203 changed the title Revert #5018 Revert PR #5018 Feb 22, 2023
@zhou1203
Copy link
Member Author

/cc @wansir

@wansir
Copy link
Member

wansir commented Feb 27, 2023

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: e24391a3187025bc26b3e43f75c9a2998743e27d

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wansir, zhou1203

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@ks-ci-bot ks-ci-bot merged commit 9dad732 into kubesphere:master Feb 27, 2023
sekfung pushed a commit to sekfung/kubesphere that referenced this pull request Mar 2, 2023
Revert "[KS-OIDC] Remove special characters form sub OIDC standard claim (kubesphere#5018)"

This reverts commit 45a0625.
@zhou1203 zhou1203 deleted the revert-5018 branch March 21, 2023 09:33
sologgfun pushed a commit to sologgfun/kubesphere that referenced this pull request Apr 24, 2023
Revert "[KS-OIDC] Remove special characters form sub OIDC standard claim (kubesphere#5018)"

This reverts commit 45a0625.
wanjunlei pushed a commit to wanjunlei/kubesphere that referenced this pull request Aug 11, 2023
Revert "[KS-OIDC] Remove special characters form sub OIDC standard claim (kubesphere#5018)"

This reverts commit 45a0625.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User ID of Third-party users with special characters cannot register in KS
3 participants