Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis/resources: support for searching alias in annotations #5807

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

iawia002
Copy link
Member

@iawia002 iawia002 commented Jul 3, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

ref #5708 #5801

Special notes for reviewers:

Does this PR introduced a user-facing change?

Support for searching alias in annotations.

Additional documentation, usage docs, etc.:


/cc @wansir

@ks-ci-bot ks-ci-bot requested a review from wansir July 3, 2023 10:10
@ks-ci-bot ks-ci-bot added release-note kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2023
@wansir
Copy link
Member

wansir commented Jul 4, 2023

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 59478424d0369ca80656f8b2fc81407d7a42ceea

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iawia002, wansir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2023
@ks-ci-bot ks-ci-bot merged commit 3b8c12f into kubesphere:master Jul 4, 2023
3 checks passed
@iawia002 iawia002 deleted the alias-search branch July 4, 2023 03:25
wanjunlei pushed a commit to wanjunlei/kubesphere that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants