Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rule_type label to indicate rule type #5834

Merged
merged 1 commit into from Jul 18, 2023
Merged

Conversation

junotx
Copy link
Contributor

@junotx junotx commented Jul 10, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

add rule_type label to the rule's labels to mark the rule type, and alerts generated by the rule will also be with this label

Which issue(s) this PR fixes:

Fixes #
#5827

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: junot <junotxiang@kubesphere.io>
@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2023
@junotx junotx requested a review from benjaminhuo July 10, 2023 06:35
@benjaminhuo
Copy link
Member

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: dbd025acb507d71e6c6c552f4dfe523235fb3c46

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminhuo, junotx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@ks-ci-bot ks-ci-bot merged commit aa0da0c into kubesphere:master Jul 18, 2023
3 checks passed
wanjunlei pushed a commit to wanjunlei/kubesphere that referenced this pull request Aug 11, 2023
add rule_type label to indicate rule type (kubesphere#472)

Signed-off-by: junot <junotxiang@kubesphere.io>
@ImitationImmortal
Copy link

ImitationImmortal commented Oct 30, 2023

/cherrypick release-3.4

1 similar comment
@wansir
Copy link
Member

wansir commented Oct 30, 2023

/cherrypick release-3.4

@ks-ci-bot
Copy link
Collaborator

@wansir: new pull request could not be created: failed to create pull request against kubesphere/kubesphere#release-3.4 from head ks-ci-bot:cherry-pick-5834-to-release-3.4: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubesphere:release-3.4 and ks-ci-bot:cherry-pick-5834-to-release-3.4"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherrypick release-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants