New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rule_type label to indicate rule type #5834
Conversation
Signed-off-by: junot <junotxiang@kubesphere.io>
/lgtm |
LGTM label has been added. Git tree hash: dbd025acb507d71e6c6c552f4dfe523235fb3c46
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminhuo, junotx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
add rule_type label to indicate rule type (kubesphere#472) Signed-off-by: junot <junotxiang@kubesphere.io>
/cherrypick release-3.4 |
1 similar comment
/cherrypick release-3.4 |
@wansir: new pull request could not be created: failed to create pull request against kubesphere/kubesphere#release-3.4 from head ks-ci-bot:cherry-pick-5834-to-release-3.4: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubesphere:release-3.4 and ks-ci-bot:cherry-pick-5834-to-release-3.4"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
add
rule_type
label to the rule's labels to mark the rule type, and alerts generated by the rule will also be with this labelWhich issue(s) this PR fixes:
Fixes #
#5827
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: