optimize queries #251
Merged
optimize queries #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gentleelephant <moon0hello@gmail.com>
benjaminhuo
reviewed
Mar 11, 2024
| if !ok { | ||
| array = make(map[string]string) | ||
| } | ||
| array[user] = "" |
There was a problem hiding this comment.
user 用map[string]string 存有必要吗？ value 里面除了"" 还会存什么？
make(map[string]map[string]string):
map[namespace]map[user]""
user 直接是个 string 会有什么问题？影响之前的代码？
make(map[string]string)
map[namespace]user
There was a problem hiding this comment.
一个 ns 会有多个 user 有权限访问，用 map 存 user 是为了提高查询效率
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.