Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor porter #132

Merged
merged 1 commit into from Nov 24, 2020
Merged

refactor porter #132

merged 1 commit into from Nov 24, 2020

Conversation

duanjiong
Copy link
Contributor

  1. Eip Address Management via CRD
  2. refactor Porter High Availability
  3. Changes to the BgpConf/BgpPeer API to be compatible with the gobgp API and to support viewing status.
  4. Some other changes

Signed-off-by: Duan Jiong djduanjiong@gmail.com

@duanjiong
refactor porter
c1111d0 
1. Eip Address Management via CRD
2. refactor Porter High Availability
3. Changes to the BgpConf/BgpPeer API to be compatible with the gobgp API and to support viewing status.
4. Some other changes

Signed-off-by: Duan Jiong <djduanjiong@gmail.com>
@ks-ci-bot ks-ci-bot added dco-signoff: yes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 24, 2020
@duanjiong
Copy link
Contributor Author

/assign @zheng1

zheng1
zheng1 reviewed Nov 24, 2020
View reviewed changes
config/samples/network_v1alpha2_bgpconf.yaml
metadata:
#The porter only recognizes configurations with default names;
#configurations with other names are ignored.
name: default
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about set the name to porter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but the name default is used both in the code and in the documentation, so I don't want to change it, and it's not really perceptible to the user when it's configured through the UI.

@zheng1
Copy link
Collaborator

zheng1 commented Nov 24, 2020

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duanjiong, zheng1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2020
@ks-ci-bot ks-ci-bot merged commit cd7dce2 into openelb:master Nov 24, 2020
@zheng1
Copy link
Collaborator

zheng1 commented Nov 24, 2020

Here is some error

root@master:~# kubectl apply -f https://raw.githubusercontent.com/kubesphere/porter/master/deploy/porter.yaml
namespace/porter-system unchanged
customresourcedefinition.apiextensions.k8s.io/bgpconfs.network.kubesphere.io configured
customresourcedefinition.apiextensions.k8s.io/bgppeers.network.kubesphere.io configured
customresourcedefinition.apiextensions.k8s.io/eips.network.kubesphere.io configured
role.rbac.authorization.k8s.io/leader-election-role unchanged
error: error parsing https://raw.githubusercontent.com/kubesphere/porter/master/deploy/porter.yaml: error converting YAML to JSON: yaml: line 44: did not find expected '-' indicator

@duanjiong
Copy link
Contributor Author

duanjiong commented Nov 24, 2020 •
edited

Here is some error

root@master:~# kubectl apply -f https://raw.githubusercontent.com/kubesphere/porter/master/deploy/porter.yaml
namespace/porter-system unchanged
customresourcedefinition.apiextensions.k8s.io/bgpconfs.network.kubesphere.io configured
customresourcedefinition.apiextensions.k8s.io/bgppeers.network.kubesphere.io configured
customresourcedefinition.apiextensions.k8s.io/eips.network.kubesphere.io configured
role.rbac.authorization.k8s.io/leader-election-role unchanged
error: error parsing https://raw.githubusercontent.com/kubesphere/porter/master/deploy/porter.yaml: error converting YAML to JSON: yaml: line 44: did not find expected '-' indicator

There was an indentation error, the keyboard mishandled when I submitted it.

@FeynmanZhou
Copy link
Member

FeynmanZhou commented Mar 16, 2021 •
edited

@Patrick-LuoYu @duanjiong @zheng1 Do we have the relevant guides for these two features in v0.4.0? How to test them from the end user side?

@duanjiong
Copy link
Contributor Author

@Patrick-LuoYu @duanjiong @zheng1 Do we have the relevant guides for these two features in v0.4.0? How to test them from the end user side?

End-users look at the documentation on the line, unclear we improve the documentation, there are problems with the issue we fix on the line, with the use of documentation is also a test, why do we have to get a separate set of test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zheng1 zheng1 zheng1 left review comments

Assignees

@zheng1 zheng1

@FeynmanZhou FeynmanZhou

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@duanjiong @zheng1 @ks-ci-bot @FeynmanZhou