Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the format of DEVELOPMENT.md #142

Merged
merged 1 commit into from Nov 6, 2020
Merged

Unify the format of DEVELOPMENT.md #142

merged 1 commit into from Nov 6, 2020

Conversation

LinuxSuRen
Copy link
Member

No description provided.

@LinuxSuRen
Unify the format of document
7f441bd 
Signed-off-by: rick <rick@jenkins-zh.cn>
@LinuxSuRen LinuxSuRen changed the title Unify the format of document Unify the format of DEVELOPMENT.md Nov 4, 2020
@ks-ci-bot ks-ci-bot added dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Nov 4, 2020
@ks-ci-bot
Copy link
Collaborator

Hi @LinuxSuRen. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shaowenchen
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2020
@shaowenchen
Copy link
Contributor

/kind documentation

@ks-ci-bot ks-ci-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 5, 2020
@shaowenchen
Copy link
Contributor

/approve

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2020
@shaowenchen
Copy link
Contributor

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, shaowenchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaowenchen shaowenchen merged commit 7186a96 into kubesphere:master Nov 6, 2020
@LinuxSuRen LinuxSuRen deleted the improve-dev-doc branch November 6, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shaowenchen shaowenchen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LinuxSuRen @ks-ci-bot @shaowenchen