Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notes in Create Pipeline Using Jenkinsfile/Editing Panels-v3.1 #1296

Merged
merged 4 commits into from May 7, 2021

Conversation

Felixnoo
Copy link
Contributor

Signed-off-by: Felixnoo felixliu@yunify.com

Signed-off-by: Felixnoo <felixliu@yunify.com>
@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 31, 2021
@Felixnoo
Copy link
Contributor Author

/assign @Sherlock113 Please review the updates I made in those two documents, thanks.
/cc @kubesphere/sig-devops I made some updates in the documents to show new DevOps features in v3.1. Please help review them, thanks.

@Felixnoo
Copy link
Contributor Author

Felixnoo commented Apr 2, 2021

@kubesphere/sig-devops Please help review the updates I made in this PR when you guys are available, thanks.

Comment on lines 99 to 104

{{< notice note >}}

The **Sync Status** colume shows the synchronization result between KubeSphere and Jenkins, and you can see the icon of **Success** if the synchronization is successful.

{{</ notice >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold on about this part. We're still under discussion about this. See also kubesphere/kubesphere#3639

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this part in the PR.


{{< notice note >}}

In KubeSphere v3.1, only pipeline creator, account with the role of admin in the project, or the account you specify will have the authority to continue or terminate the pipeline.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're two cases here:

  • First, anyone who can run this pipeline, then he can approve or reject it if there are no specific approvers
  • Second, same as you described above

Copy link
Contributor Author

@Felixnoo Felixnoo Apr 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment and I made some changes in this commit.

Signed-off-by: Felixnoo <felixliu@yunify.com>
@Sherlock113 Sherlock113 self-assigned this Apr 8, 2021
Signed-off-by: Felixnoo <felixliu@yunify.com>
@Felixnoo
Copy link
Contributor Author

/cc @LinuxSuRen I added new words about sync status in this commit. Please take a look when you are available, thanks.

@Sherlock113
Copy link
Contributor

@LinuxSuRen Hi, do you have any comments about this pr?

@Felixnoo
Copy link
Contributor Author

Felixnoo commented May 6, 2021

@LinuxSuRen Hi, please take a look at this PR when you are available.

Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2021
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Felixnoo, LinuxSuRen
To complete the pull request process, please assign sherlock113
You can assign the PR to them by writing /assign @sherlock113 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -302,6 +311,12 @@ This stage uses SonarQube to test your code. You can skip this stage if you do n

![input-message](/images/docs/devops-user-guide/using-devops/create-a-pipeline-using-graphical-editing-panels/input-message.jpg)

{{< notice note >}}

In KubeSphere v3.1, the account that can run the pipeline will be able to continue or terminate the pipeline if there is no approver specified. Moreover, pipeline creator, account with the role of admin in the project, or the account you specify will have the authority to continue or terminate the pipeline.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

->
In KubeSphere v3.1, the account that can run a pipeline will be able to continue or terminate the pipeline if there is no reviewer specified. Pipeline creators, accounts with the role of admin in a project, or the account you specify will be able to continue or terminate a pipeline.


{{< notice note >}}

On the **Pipelines** page, you can click the three dots on the right side of the pipeline and then select **Copy Pipeline** to create a copy of it. If you need to concurrently run multiple pipelines that don't contain multiple branches, you can select all of those pipelines and then click **Run** to run them in a batch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

select all of those pipelines
->
select all of these pipelines

@@ -205,6 +205,13 @@ The account `project-admin` needs to be created in advance since it is the revie

![pipeline-list](/images/docs/devops-user-guide/using-devops/create-a-pipeline-using-a-jenkinsfile/pipeline-list.jpg)

{{< notice note >}}

- You can click the three dots on the right side of the pipeline and then select **Copy Pipeline** to create a copy of it. If you need to concurrently run multiple pipelines that don't contain multiple branches, you can select all of those pipelines and then click **Run** to run them in a batch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

select all of those pipelines
->
select all of these pipelines


{{< notice note >}}

In KubeSphere v3.1, the account that can run the pipeline will be able to continue or terminate the pipeline if there is no approver specified. Moreover, pipeline creator, account with the role of admin in the project, or the account you specify will have the authority to continue or terminate the pipeline.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

->
In KubeSphere v3.1, the account that can run a pipeline will be able to continue or terminate the pipeline if there is no reviewer specified. Pipeline creators, accounts with the role of admin in the project, or the account you specify will be able to continue or terminate the pipeline.

Signed-off-by: Felixnoo <felixliu@yunify.com>
@ks-ci-bot ks-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2021
@Sherlock113
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2021
@Sherlock113 Sherlock113 merged commit 797546b into kubesphere:master May 7, 2021
@Felixnoo Felixnoo deleted the add-notes branch May 7, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants