Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Wording in 3.2.0 DevOps ZH Docs #2120

Merged
merged 1 commit into from Nov 17, 2021

Conversation

Felixnoo
Copy link
Contributor

Signed-off-by: Felixnoo felixliu@kubesphere.io

/cc @kubesphere/sig-devops
Since the UI text on KubeSphere 3.2.0 web console is updated and DevOps project is translated into DevOps 项目 in Chinese, I updated relevant ZH documents accordingly in this PR.
Please take a look, thanks.

Signed-off-by: Felixnoo <felixliu@kubesphere.io>
@netlify
Copy link

netlify bot commented Nov 17, 2021

✔️ Deploy Preview for kubesphere-v3-1 ready!

🔨 Explore the source changes: 8760f88

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubesphere-v3-1/deploys/6194c5682bba3900085bb2d4

😎 Browse the preview: https://deploy-preview-2120--kubesphere-v3-1.netlify.app

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 17, 2021
@Felixnoo Felixnoo removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 17, 2021
@Felixnoo
Copy link
Contributor Author

/area devops

@@ -12,9 +12,9 @@ weight: 11430
- 您需要有一个 [Docker Hub](http://www.dockerhub.com/) 帐户。
- 您需要创建一个企业空间、一个 DevOps 项目和一个用户,并需要邀请该用户至 DevOps 项目中并赋予 `operator` 角色。有关更多信息,请参见[创建企业空间、项目、用户和角色](../../../quick-start/create-workspace-and-project/)。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link of create-workspace-and-project seems linked to a '404' error page, it should be '../../../quick-start/create-workspace-and-project.md'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your review. The link here is correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the trouble.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries.

@@ -73,7 +73,7 @@ kubectl get cm -n kubesphere-devops-system ks-devops-agent -o yaml

在本示例中,所有工作负载都部署在 `kubesphere-sample-dev` 项目中。您必须事先创建 `kubesphere-sample-dev` 项目。

### 为 Maven 工程创建一个流水线
### 为 Maven 项目创建一个流水线

1. 在您的 DevOps 项目中,转到**流水线**页面并点击**创建**,创建一个名为 `maven` 的流水线。有关更多信息,请参见[使用图形编辑面板创建流水线](../../how-to-use/create-a-pipeline-using-graphical-editing-panel)。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link of create-a-pipeline-using-graphical-editing-panel should be ../../devops-user-guide/how-to-use/create-a-pipeline-using-graphical-editing-panel.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your review. The link here is correct.

@mangoGoForward
Copy link
Member

Seems no problem. Maybe we can create a new issue to solve those link error.

@JohnNiang
Copy link
Member

Hi @mangoGoForward , thanks for your patient review.

I suggest clicking the Details link to preview the document to check if the link is correct:

image

@mangoGoForward
Copy link
Member

Hi @mangoGoForward , thanks for your patient review.

I suggest clicking the Details link to preview the document to check if the link is correct:

image

Thanks, it helped me a lot, and looks no problem. I clicked the link in markdown file, and redirect to an error page, so I leave those comments, Do we need to process this scene?

@JohnNiang
Copy link
Member

Do we need to process this scene?

I think it would be a huge change. At present, I suggest not to handle this issue.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Felixnoo, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021
@ks-ci-bot ks-ci-bot merged commit a363682 into kubesphere:master Nov 17, 2021
@Felixnoo Felixnoo deleted the update-zh-devops branch November 17, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants