✨Separate CRDs in the Helm chart #1920
Conversation
Signed-off-by: francostellari <fstellari@gmail.com>
kcp-ci-bot
added
dco-signoff: yes
Signed-off-by: francostellari <fstellari@gmail.com>
config/default/kustomization.yaml
Outdated
| @@ -15,7 +15,7 @@ namePrefix: kubestellar- | |||
| # someName: someValue | |||
|
|
|||
| resources: | |||
| - ../crd | |||
| # - ../crd | |||
There was a problem hiding this comment.
What was this kustomization accomplishing?
If we are no longer going to use that, perhaps it should be deleted?
There was a problem hiding this comment.
Removing this line prevents the CRDs from being injected into the chart template yaml.
When doing the same in kubefkex and otp, we commented the line instead of completely removing it.
I can remove it if you prefer
There was a problem hiding this comment.
I think it's better to just remove it
There was a problem hiding this comment.
In my own testing and analysis, it appears that this particular line was accomplishing nothing. It is a bit of generic infrastructure inserted by kubebuilder, but it never made a difference in this repo.
There was a problem hiding this comment.
@MikeSpreitzer correct, at least for the CRD there is currently no kustomization done.
Signed-off-by: francostellari <fstellari@gmail.com>
|
LGTM label has been added. Git tree hash: 9b155ae16b8775dadcacdfea95e74fbafe885820
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MikeSpreitzer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Summary
Move CRDs to the chart
crds/folder to let Helm install them before applying the templateRelated issue(s)
Fixes #