馃尡 Make unit tests not require envtest #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. because they are not relying on it. envtest might be useful for integration tests. Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
kcp-ci-bot
added
dco-signoff: yes
MikeSpreitzer
changed the title
|
/cc @pdettori |
kcp-ci-bot
requested review from
ezrasilvera,
nirrozenbaum,
pdettori and
waltforme
|
/lgtm |
|
LGTM label has been added. Git tree hash: 4595b511c33e3b0a7111744aacea8b81adfb38eb
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: waltforme The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This test removes the dependency of our unit tests on
envtest. This is good because our unit tests are not relying onenvtestand becauseenvtestis (a) designed to support integration tests rather than unit tests and (b) made for working with controller-runtime based controllers but our controllers are not full-fledged controller-runtime based controllers and our trend is to make them less so rather than more.Related issue(s)
Fixes #